Skip to content

gh-131254: ensure that BROWSER is not set for test_webbrowser on macOS #131276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 16, 2025
Merged

gh-131254: ensure that BROWSER is not set for test_webbrowser on macOS #131276

merged 3 commits into from
Mar 16, 2025

Conversation

@picnixz
Copy link
Member

@picnixz picnixz commented Mar 15, 2025 •
edited by bedevere-app bot
Loading

@smontanaro Can you confirm that this fixes your issue? I'll run the macOS build bots but those don't have a BROWSER set I think.

@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Mar 15, 2025
@bedevere-app bedevere-app bot mentioned this pull request Mar 15, 2025
Closed
@picnixz

This comment was marked as outdated.

Sign in to view
@bedevere-bot

This comment was marked as outdated.

Sign in to view
@picnixz picnixz added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 15, 2025
picnixz
picnixz commented Mar 16, 2025
View reviewed changes
@picnixz
Copy link
Member Author

picnixz commented Mar 16, 2025

!buildbot macOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @picnixz for commit a32c280 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131276%2Fmerge

The command will test the builders whose names match following regular expression: macOS

The builders matched are:

  • x86-64 MacOS Intel NoGIL PR
  • x86-64 macOS PR
  • ARM64 MacOS M1 NoGIL PR
  • x86-64 MacOS Intel ASAN NoGIL PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • ARM64 macOS PR

@picnixz picnixz self-assigned this Mar 16, 2025
@picnixz picnixz merged commit 9b6cef0 into python:main Mar 16, 2025
44 checks passed
@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Sorry, @picnixz, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9b6cef0f5dcb309096a68fdd04158e0e1313e8ec 3.13

@picnixz picnixz changed the title gh-131254: ensure that BROWSER is not set for test_webbrowser on macOS. gh-131254: ensure that BROWSER is not set for test_webbrowser on macOS Mar 16, 2025
@miss-islington-app
Copy link

Sorry, @picnixz, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9b6cef0f5dcb309096a68fdd04158e0e1313e8ec 3.12

@picnixz
Copy link
Member Author

picnixz commented Mar 16, 2025

I'll do the backports tomorrow

@picnixz picnixz deleted the fix/webbrowser/mac-env-131254 branch March 16, 2025 15:32
@picnixz
Copy link
Member Author

picnixz commented Mar 16, 2025

Actually, no need for backports because the test was added just past month #130535

@picnixz picnixz removed needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 16, 2025
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
@picnixz @plashchynski
pythongh-131254: ensure that BROWSER is not set for `test_webbrowse…
b4bf7df 
…r` on macOS (python#131276)
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@picnixz @seehwan80
pythongh-131254: ensure that BROWSER is not set for `test_webbrowse…
b8c1202 
…r` on macOS (python#131276)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@picnixz picnixz

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz @bedevere-bot